search

BHoM / LifeCycleAssessment_Toolkit

GNU Lesser General Public License v3.0
22 stars 5 forks source link

Inconsistent 0 Volume behavior for mass vs volume based epd's #237

Closed enarhi closed 1 year ago

enarhi commented 3 years ago

Description:

When evaluating EPD for elements with Volumes equal to zero, we get different behavior depending if the epd uses a per mass or per area calculation. These should behave the same, with a correction to either the mass handling allowing zero volume or the catch on volume calc's not allowing 0 volume being removed. A possible solution is to record a warning for both methods when volume=0, so that a result is still returned with quantity=0. This would also allow the EvaluateLCA method to work if the input includes 0 volume elements, returning warnings for 0 volume elements rather than throwing a breaking error. Image for reference of varying behavior below: image

michaelhoehn commented 1 year ago

@enarhi I've just had a go at replicating your issue here with no luck. Could you possibly provide a sample script to help with behavior verification?

Please review this sample script to see if I'm on the right track here. I'm seeing zero volume mass-based epds return zero, and area-based epds return a valid calculation.

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/LifeCycleAssessment_Toolkit/%23237%20zero%20volume%20behavior.gh?csf=1&web=1&e=88C6CH

enarhi commented 1 year ago

Happy with this closed. Separate issue will be raised for general Eval method error handling.