BHoM / LifeCycleAssessment_Toolkit

GNU Lesser General Public License v3.0
22 stars 5 forks source link

Add EPiC Datasets #245

Closed michaelhoehn closed 1 year ago

michaelhoehn commented 2 years ago

NOTE: Depends on

Issues addressed by this PR

Closes #244

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/LifeCycleAssessment_Toolkit/%23244-EPiC%20Database/EpicDatabase.gh?csf=1&web=1&e=45wgpn

Changelog

Additional comments

kayleighhoude commented 2 years ago

Any way that we'd be able to grab the density too? Not sure if it's in the raw dataset: image

kayleighhoude commented 2 years ago

Outside of the phase issue everything looks great! Super happy to have this dataset, please lmk when this is ready for review again! @michaelhoehn

michaelhoehn commented 2 years ago

Please add additional phases (A2, A3) understand from our conversation that this was an Excel Toolkit issue

Done!

Any way that we'd be able to grab the density too? Not sure if it's in the raw dataset:

This metric isn't in their formatted xml database, but it is in each of the documentation material linked in the database. Since that will take hours to scrape I suggest we move ahead with the dataset as is and get some additional resource to add the density fragments at a later stage.

Adding the actual Density fragment is a trival matter, but scraping is the time consuming bit that can be added in the next feature sprint.

If that's acceptable I believe this PR is ready for approval.

michaelhoehn commented 2 years ago

@BHoMBot check compliance please

bhombot-ci[bot] commented 2 years ago
@michaelhoehn to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance`
michaelhoehn commented 2 years ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 years ago
@michaelhoehn to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance`
michaelhoehn commented 2 years ago

@BHoMBot check core @BHoMBot check installer @BHoMBot check null handling @BHoMBot check serialisation @BHoMBot check versioning

bhombot-ci[bot] commented 2 years ago
@michaelhoehn to confirm, the following checks are now queued: - `core` - `installer` - `serialisation` - `versioning`
michaelhoehn commented 2 years ago

@BHoMBot check null-handling

bhombot-ci[bot] commented 2 years ago
@michaelhoehn to confirm, the following checks are now queued: - `null-handling` There are 8 requests in the queue ahead of you.
michaelhoehn commented 2 years ago

@kayleighhoude how are we looking for a rereview on this one?

kayleighhoude commented 2 years ago

@michaelhoehn went to review this and I think because of the Reflection oM not existing anymore it won't build, any ideas on how to repair?

michaelhoehn commented 1 year ago

This has been rebased and is ready for review and merge @kayleighhoude @enarhi @shivanierambaran prior to Jan. 11th

FYI @FraserGreenroyd as part of the PR closer initiative 🦖

michaelhoehn commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 11 requests in the queue ahead of you.
michaelhoehn commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
FraserGreenroyd commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 5 requests in the queue ahead of you.
michaelhoehn commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
michaelhoehn commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
michaelhoehn commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `ready-to-merge`