Closed michaelhoehn closed 1 year ago
Any way that we'd be able to grab the density too? Not sure if it's in the raw dataset:
Outside of the phase issue everything looks great! Super happy to have this dataset, please lmk when this is ready for review again! @michaelhoehn
Please add additional phases (A2, A3) understand from our conversation that this was an Excel Toolkit issue
Done!
Any way that we'd be able to grab the density too? Not sure if it's in the raw dataset:
This metric isn't in their formatted xml database, but it is in each of the documentation material linked in the database. Since that will take hours to scrape I suggest we move ahead with the dataset as is and get some additional resource to add the density fragments at a later stage.
Adding the actual Density fragment is a trival matter, but scraping is the time consuming bit that can be added in the next feature sprint.
If that's acceptable I believe this PR is ready for approval.
@BHoMBot check compliance please
@BHoMBot check compliance
@BHoMBot check core @BHoMBot check installer @BHoMBot check null handling @BHoMBot check serialisation @BHoMBot check versioning
@BHoMBot check null-handling
@kayleighhoude how are we looking for a rereview on this one?
@michaelhoehn went to review this and I think because of the Reflection oM not existing anymore it won't build, any ideas on how to repair?
This has been rebased and is ready for review and merge @kayleighhoude @enarhi @shivanierambaran prior to Jan. 11th
FYI @FraserGreenroyd as part of the PR closer initiative 🦖
@BHoMBot check compliance
@BHoMBot check required
@BHoMBot check ready-to-merge
@BHoMBot check required
@BHoMBot check compliance
@BHoMBot check ready-to-merge
NOTE: Depends on
Issues addressed by this PR
Closes #244
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/LifeCycleAssessment_Toolkit/%23244-EPiC%20Database/EpicDatabase.gh?csf=1&web=1&e=45wgpn
Changelog
Additional comments