BHoM / LifeCycleAssessment_Toolkit

GNU Lesser General Public License v3.0
22 stars 5 forks source link

Evaluation methods fail when using a single Material with Properties input #258

Closed michaelhoehn closed 1 year ago

michaelhoehn commented 2 years ago

Description:

This issue basically identifies the applicable differences in Construction creation. In the first instance a user can create a custom construction using two distinct Materials with two distinct Layers that combine to create a single Construction.

The second application suggests a Construction that is comprised of a single Material with multiple properties.

I don't believe either of these is inherently incorrect per se, but I do think the flexibility of these applications does produce something intrinsically different but is still deemed the "same" object.

This introduces a bit of complexity into the code of the LCA engine as it currently iterates over individual properties, rather than any Material containing a list of properties.

Steps to reproduce:

image

Expected behaviour:

I would expect both types of Material Properties would produce the same value, which is currently not the case.

image

Test file(s):

Test File

michaelhoehn commented 1 year ago

This seems to be user setup error, which should be documented in the wiki at some point to guide people on best practices. Closing this issue.