BHoM / LifeCycleAssessment_Toolkit

GNU Lesser General Public License v3.0
22 stars 5 forks source link

Align with changes in oM and Engine on Reflection -> Base #263

Closed FraserGreenroyd closed 2 years ago

FraserGreenroyd commented 2 years ago

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1339 https://github.com/BHoM/BHoM_Engine/pull/2729 https://github.com/BHoM/BHoM_Adapter/pull/318

Issues addressed by this PR

Test files

Changelog

Additional comments

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM
FraserGreenroyd commented 2 years ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `project-compliance` There are 6 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `4788308766`
FraserGreenroyd commented 2 years ago

@BHoMBot fix project file ref. 4788308766

bhombot-ci[bot] commented 2 years ago
@frasergreenroyd I am now going to fix the CSProject compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 2 years ago
@frasergreenroyd to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request.
FraserGreenroyd commented 2 years ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `project-compliance` There are 4 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoMAnalytics_Toolkit
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine
FraserGreenroyd commented 2 years ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, code-compliance, copyright-compliance, dataset-compliance, documentation-compliance, null-handling, project-compliance, ready-to-merge, serialisation

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.