Supporting core oM updates with removal of scope object classes

[michaelhoehn]

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1370

Issues addressed by this PR

Closes #264 Closes https://github.com/BHoM/LifeCycleAssessment_Toolkit/issues/248

Test files

Test file

Changelog

Additional comments

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `core`

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `core`

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[michaelhoehn]

@BHoMBot check compliance

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance`

[michaelhoehn]

In a testing session with @enarhi we noticed that the user note for missing scopes was firing undesirably when called in a typical eval method. This note is being triggered in GetElementScope() and should possibly be moved to a different query more focused on curated reports at a later stage (something like IsScopeValid() when preparing a very specific report from study outputs).

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[FraserGreenroyd]

@BHoMBot check code-compliance

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following checks are now queued: - `code-compliance`

[FraserGreenroyd]

@BHoMBot check documentation-compliance

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following checks are now queued: - `documentation-compliance`

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[michaelhoehn]

@BHoMBot check compliance

[michaelhoehn]

@enarhi caught another couple of instances as well. Thanks for highlighting these. Pretty awesome boost to the runtime as well. Previous tests on a sample set of objects were evaluated at around 800ms, and with these changes we are around 130ms for the same set.

[michaelhoehn]

@BHoMBot check required

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `core` - `null-handling` - `serialisation` - `versioning` - `installer`

[michaelhoehn]

@BHoMBot check compliance

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance` There are 14 requests in the queue ahead of you.

[michaelhoehn]

@BHoMBot check documentation

[bhombot-ci[bot]]

@michaelhoehn sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to do? For a list of available instructions, please see [this wiki page](https://github.com/BHoM/documentation/wiki/Continuous-Integration).

[michaelhoehn]

@BHoMBot check compliance

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance`

[michaelhoehn]

@BHoMBot check compliance

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance`

[michaelhoehn]

@BHoMBot check null-handling

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `null-handling`

[michaelhoehn]

@BHoMBot check compliance

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance`

[michaelhoehn]

@BHoMBot check core @BHoMBot check serialisation

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `core` - `serialisation`

[michaelhoehn]

@BHoMBot check core

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `core`

[bhombot-ci[bot]]

@michaelhoehn just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

[michaelhoehn]

@BHoMBot check null-handling

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `null-handling`

[michaelhoehn]

@BHoMBot check null-handling

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `null-handling`

[michaelhoehn]

@BHoMBot check null-handling

[bhombot-ci[bot]]

@michaelhoehn to confirm, the following checks are now queued: - `null-handling` There are 9 requests in the queue ahead of you.

[michaelhoehn]

@BHoMBot check null-handling