BHoM / LifeCycleAssessment_Toolkit

GNU Lesser General Public License v3.0
22 stars 5 forks source link

Refactor of evaluation methods and new result classes #288

Closed IsakNaslundBh closed 1 year ago

IsakNaslundBh commented 1 year ago

NOTE: Depends on

https://github.com/BHoM/BHoM_Engine/pull/2932 https://github.com/BHoM/BHoM/pull/1449

Issues addressed by this PR

Full refactor and renaming of the evaluation method. Happy to keep the previous name, but adding as greenfield for comparison reasons. New method is returning new results added in https://github.com/BHoM/BHoM/pull/1449

Adding method for evaluating a volumetric takeoff

Adding methods for getting total breakdown by material

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EuOfKi2RtkhCrcHtJGGGH64BqnRs2fZlVgaI6u8EGUQ1tg?e=tp1d6U

Changelog

Additional comments

michaelhoehn commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
michaelhoehn commented 1 year ago

@BHoMBot check core

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `core` There are 9 requests in the queue ahead of you.
michaelhoehn commented 1 year ago

@BHoMBot check installer

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `installer`
michaelhoehn commented 1 year ago

@BHoMBot check versioning

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `versioning` There are 9 requests in the queue ahead of you.
michaelhoehn commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 1 year ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `project-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 6 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
FAO: @FraserGreenroyd @FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is ready-to-merge. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `9834621368`
FraserGreenroyd commented 1 year ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9834621368

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have now provided a passing check on reference `9834621368` as requested.