BHoM / LifeCycleAssessment_Toolkit

GNU Lesser General Public License v3.0
22 stars 5 forks source link

Remove conditional for epd values <= 0 #304

Closed michaelhoehn closed 1 year ago

michaelhoehn commented 1 year ago

NOTE: Depends on

Issues addressed by this PR

Closes #162

Removed the conditional that was catching EPD values <= 0 and throwing an error. Please check all 4 methods that were implementing this check. Mass, Area, Volume, and Length.

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/LifeCycleAssessment_Toolkit/%23162-Fix%20GWP%20negative%20values/GWP%20negative%20value%20fix.gh?csf=1&web=1&e=tt733W

Changelog

Additional comments

FraserGreenroyd commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 72 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check core @BHoMBot check null-handling @BHoMBot check serialisation

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `core` - check `null-handling` - check `serialisation` There are 8 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check versioning

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning`
FraserGreenroyd commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 5 requests in the queue ahead of you.