BHoM / LifeCycleAssessment_Toolkit

GNU Lesser General Public License v3.0
22 stars 5 forks source link

Method added that is a converted version of LCA_tool_part_tostart.py #315

Closed EKAdebo closed 1 year ago

EKAdebo commented 1 year ago

Issues addressed by this PR

Closes #18

Converted the LCA_tool_part_tostart.py to C# and added it as an engine method.

Additional comments

As the script was originally in German I have tried to translate it, but have left some words as is, because I'm not sure of the translation. I have also tried to leave the script fairly similar to the original python script as I am not familiar with the calculations done within the script.

jamesramsden-bh commented 1 year ago

Without being familiar with LCA, I think the missing translations are: flachen = areas (I think it's supposed to be flächen, maybe you can't have umlauts in python?) parken = car park / parking area line 657 - I think 'hohe' is supposed to be 'height', maybe a tank height? (höhe = height)

EKAdebo commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
EKAdebo commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
EKAdebo commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 12 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
EKAdebo commented 1 year ago

@BHoMBot check core

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `core` There are 29 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
EKAdebo commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 1 year ago
The check `core` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `versioning` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
EKAdebo commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 1 year ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 1 year ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `copyright-compliance` - check `dataset-compliance` There are 4 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 4 requests in the queue ahead of you.