search

BHoM / LifeCycleAssessment_Toolkit

GNU Lesser General Public License v3.0
22 stars 5 forks source link

EPD Assignment Method for FrameEdgeProperties #318

Closed vgreen-BH closed 1 year ago

vgreen-BH commented 1 year ago

Issues addressed by this PR

Closes #317

Method that helps apply EPDs to the section properties included in a facade FrameEdgeProperty.

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BHoM/LifeCycleAssessment_Toolkit/TestEPDAssignMethod.gh?csf=1&web=1&e=4tN2h3?csf=1&web=1&e=4tN2h3

Additional comments

This method is currently under the LifeCycleAssessment_Toolkit. Isak and Erik to review if it should be relocated to Facade_Engine.

FraserGreenroyd commented 1 year ago

This PR has come in during the middle of a drafted refactor and will conflict with it. As such, am closing this PR in favour of the work being done later, in Facade Engine, after proper planning.

enarhi commented 1 year ago

Noting intent for this PR as WIP to follow up the refactor, with the PR and code for reference. @IsakNaslundBh please coordinate with @vgreen-BH to incorporate at your soonest convenience. @FraserGreenroyd, if per your comment this will go in Facade_Engine we can move there accordingly as well. Either way, @vgreen-BH and @IsakNaslundBh are to coordinate inclusion of this PR's functionality when appropriate.