Fixed bug where there was a unit conversion error for some datasets

peterjamesnugent commented 9 months ago

Issues addressed by this PR

Closes #340

Test files

Check dataset for National Highways - this imports the spreadsheet, and carries out a conversion to SI units to compare against the dataset.

National Highways dataset - this has the original data, plus a column of SI converted values as well as a column detailing the rationale behind the conversion. Some of the units are consistent, for example, laden vehicles have a quantity of km but the units work out to kgCO2_e/km⋅kg, whereby the denominator is the kg of cargo transport multiplied by the mass of the load. Similarly, there are factors for vehicle use, which have a quantity of km, but the SI units are kgCO2_e/km - without the load accounted for.

Changelog

Fixed bug whereby some of the values of the National Highways dataset were incorrect, a full review of all values in this dataset has been conducted to ensure the SI units are adhered to.

Additional comments

@michaelhoehn I noticed that during the refactoring, this dataset had a ClimateChangeTotalMetric and a ClimateChangeTotalNoBiogenicMetric - but both were the exact same. I have only added the ClimateChangeTotalMetric, but do you think we should add both back?

michaelhoehn commented 9 months ago

@BHoMBot check core

bhombot-ci[bot] commented 9 months ago

@michaelhoehn to confirm, the following actions are now queued: - check `core`

michaelhoehn commented 9 months ago

@BHoMBot check required

bhombot-ci[bot] commented 9 months ago

@michaelhoehn to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`

peterjamesnugent commented 9 months ago

@BHoMBot check dataset-compliance @BHoMBot check copyright-compliance

bhombot-ci[bot] commented 9 months ago

@peterjamesnugent to confirm, the following actions are now queued: - check `dataset-compliance` - check `copyright-compliance` There are 15 requests in the queue ahead of you.

michaelhoehn commented 9 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 9 months ago

@michaelhoehn to confirm, the following actions are now queued: - check `ready-to-merge` There are 13 requests in the queue ahead of you.

BHoM / LifeCycleAssessment_Toolkit