Fix Query.Error and ToList

BHoM / MachineLearning_Toolkit

Machine Learning for the BHoM

GNU Lesser General Public License v3.0

1 stars 1 forks source link

Fix Query.Error and ToList #80

Closed BingWangUS closed 3 years ago

BingWangUS commented 3 years ago

NOTE: Depends on

Issues addressed by this PR

Closes #65 Closes #79 Closes #81

Test files

MachineLearning#65-Scores-allModels.zip

Changelog

Move Error and Coefficients methods from Query to Structured.Compute, as they only works for models under Structured. (this fix 65)
Rename Error method to Score method, to avoid the negative term. (include versioning)
Modify Score method to work with interface oM, to avoid adding method for each model.
Modify Coefficients method to work with interface, to avoid adding method for each model.
Split oM interface
Fix ToList method to work with different types of Tensor (fix 79 and 81)

Additional comments

BingWangUS commented 3 years ago

@BHoMBot check documentation compliance

bhombot-ci[bot] commented 3 years ago

@BingWangUS to confirm, `check-documentation-compliance` task is now queued.

BingWangUS commented 3 years ago

@BHoMBot check documentation compliance

bhombot-ci[bot] commented 3 years ago

@BingWangUS to confirm, `check-documentation-compliance` task is now queued.

BingWangUS commented 3 years ago

@BHoMBot check documentation compliance

bhombot-ci[bot] commented 3 years ago

@BingWangUS to confirm, `check-documentation-compliance` task is now queued.

BingWangUS commented 3 years ago

@BHoMBot check documentation compliance

bhombot-ci[bot] commented 3 years ago

@BingWangUS to confirm, `check-documentation-compliance` task is now queued.

BingWangUS commented 3 years ago

@KentonPhillips-BH after following Fraser's comment, I took the chance to enhance coefficient method and it should work with all regression models now. Could you please re-test the updated test script to make sure it works as expected. Thanks.

BingWangUS commented 3 years ago

@FraserGreenroyd Your comment on ToList data type method points to a new bug. I give it a try to fix it but the solution now is not scalable to me. I can use some help here. Please take a look at the ToList method and let me know if you have any comment.

FraserGreenroyd commented 3 years ago

@BHoMBot check installer

bhombot-ci[bot] commented 3 years ago

@FraserGreenroyd to confirm, `check-installer` task is now queued.

FraserGreenroyd commented 3 years ago

@BHoMBot check copyright compliance

bhombot-ci[bot] commented 3 years ago

@FraserGreenroyd to confirm, `check-copyright-compliance` task is now queued.

BingWangUS commented 3 years ago

I agree @BingWangUS we might want to revisit this in the future, but for now this is working, and I don't think we have a lot of resource to improve it at this stage, so I'm happy to merge this as a working bug fix following @KentonPhillips-BH review, and we can potentially refactor in the future if you're happy with that?

Agree. Creating new issue #82 to capture this.