search

BHoM / MidasCivil_Toolkit

GNU Lesser General Public License v3.0
7 stars 3 forks source link

Make use of caching system #350

Closed peterjamesnugent closed 1 year ago

peterjamesnugent commented 1 year ago

NOTE: Depends on

https://github.com/BHoM/BHoM_Adapter/pull/337

Issues addressed by this PR

Closes #349

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/MidasCivil_Toolkit/%23349%20Using%20Cache%20from%20BHoM_Adapter?csf=1&web=1&e=gghcOs

Changelog

Added the use of caching to reduce repeated Read commands on a single Push.

Additional comments

Similar to Lusas_Toolkit test, although it will be much quicker Please check that the file combines and can be loaded

Objects develop PR
Bars and Panels 70ms 81ms
Loads 80 ms 67 ms
Nodes and Bars 124 ms 81ms
peterjamesnugent commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
FraserGreenroyd commented 1 year ago

@BHoMBot check copyright-compliance @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `copyright-compliance` - check `ready-to-merge` There are 4 requests in the queue ahead of you.