BHoM / MidasCivil_Toolkit

GNU Lesser General Public License v3.0
7 stars 3 forks source link

Add support for pushing and pulling of custom sections #355

Closed peterjamesnugent closed 1 year ago

peterjamesnugent commented 1 year ago

Issues addressed by this PR

Closes #332

Test files

Push and pull

Changelog

Added support for pushing FreeformProfile Added support for pulling PSC-Value General sections

Additional comments

~The Shear Factor for Shear Stress (Qby, Qbz) is not clear how to calculate it for PSC-Value sections - I have contacted Midas regarding this.~ Added calculation. ~The Asy and Asz is also different to what our integration method is calculation - so will need some testing.~ Will leave it based on integration methods. ~There is also a visual bug for plates at 40mm.~ Purely visual.

Tickets raised here: https://globalsupport.midasuser.com/helpdesk/Ticket/61518403 https://globalsupport.midasuser.com/helpdesk/Ticket/61637483

peterjamesnugent commented 1 year ago

@BHoMBot check project-compliance @BHoMBot check copyright-compliance @BHoMBot check documentation-compliance @BHoMBot check null-handling @BHoMBot check serialisation

bhombot-ci[bot] commented 1 year ago
@peterjamesnugent to confirm, the following actions are now queued: - check `project-compliance` - check `copyright-compliance` - check `documentation-compliance` - check `null-handling` - check `serialisation`
peterjamesnugent commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 15 requests in the queue ahead of you.
jtrainor1 commented 1 year ago

When pushing custom sections and pulling them back in, they lose the Plastic Section Modulus values: image

jtrainor1 commented 1 year ago

When I explode the pulled Generic objects, the plastic modulus doesn't show. However, when I explode the pulled Steel Sections the plastic modulus shows: image Potentially an issue with the BH.oM.Structure.SectionProperties.GenericSection BHoM object.

FraserGreenroyd commented 1 year ago

@BHoMBot check versioning @BHoMBot check copyright-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning` - check `copyright-compliance`
FraserGreenroyd commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 11 requests in the queue ahead of you.