search

BHoM / MidasCivil_Toolkit

GNU Lesser General Public License v3.0
7 stars 4 forks source link

CreateNotExisting not working for SurfaceProperty because there is no name attribute in MidasCivil #361

Closed peterjamesnugent closed 1 year ago

peterjamesnugent commented 1 year ago

Description:

Because the version of MidasCivil does not have a naming attribute for the ConstantThickness, it cannot compare the names.

Steps to reproduce:

See test script.

Expected behaviour:

The 1 in the line below changed to bhomSurfaceProperty.Name to allow comparing when CreateNonExisting.

                    midasSurfaceProperty =
                        bhomSurfaceProperty.AdapterId<string>(typeof(MidasCivilId)) + ",VALUE,1,Yes," +
                        bhomSurfaceProperty.Thickness.LengthFromSI(lengthUnit) + ",0,No,0,0";
                    break;

Test file(s):

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/MidasCivil_Toolkit/%23361%20CreateNonExisting?csf=1&web=1&e=bg1t3p