BHoM / MidasCivil_Toolkit

GNU Lesser General Public License v3.0
7 stars 4 forks source link

Adding MidasSettings to the Adapter #364

Closed KalleEdstroem closed 1 year ago

KalleEdstroem commented 1 year ago

Issues addressed by this PR

The change makes the MidasCivilAdaptermore consistent with other adapters. It makes it functioning with the BHoMAdapter createmethod.

Closes #354

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/MidasCivil_Toolkit/%23354-ModifyingAdapterToIncludeAdapterSettings?csf=1&web=1&e=5LpPet

Changelog

Additional comments

For testing of versioning it is needed to build the Versioning_Toolkit after building this branch.

peterjamesnugent commented 1 year ago

@BHoMBot check copyright-compliance @BHoMBot check documentation-compliance @BHoMBot check project-compliance

bhombot-ci[bot] commented 1 year ago
@peterjamesnugent to confirm, the following actions are now queued: - check `copyright-compliance` - check `documentation-compliance` - check `project-compliance`
KalleEdstroem commented 1 year ago

@BHoMBot check copyright-compliance @BHoMBot check documentation-compliance @BHoMBot check project-compliance

bhombot-ci[bot] commented 1 year ago
@KalleEdstroem to confirm, the following actions are now queued: - check `copyright-compliance` - check `documentation-compliance` - check `project-compliance`
KalleEdstroem commented 1 year ago

@BHoMBot check copyright-compliance @BHoMBot check documentation-compliance @BHoMBot check project-compliance

bhombot-ci[bot] commented 1 year ago
@KalleEdstroem to confirm, the following actions are now queued: - check `copyright-compliance` - check `documentation-compliance` - check `project-compliance`
KalleEdstroem commented 1 year ago

@BHoMBot check versioning @BHoMBot check serialisation @BHoMBot check null-handling @BHoMBot check installer @BHoMBot check core

bhombot-ci[bot] commented 1 year ago
@KalleEdstroem to confirm, the following actions are now queued: - check `versioning` - check `serialisation` - check `null-handling` - check `installer` - check `core` There are 7 requests in the queue ahead of you.
KalleEdstroem commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@KalleEdstroem to confirm, the following actions are now queued: - check `ready-to-merge` There are 36 requests in the queue ahead of you.
peterjamesnugent commented 1 year ago

@BHoMBot check required @BHoMBot check copyright-compliance @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` - check `copyright-compliance` - check `ready-to-merge`
KalleEdstroem commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@KalleEdstroem to confirm, the following actions are now queued: - check `ready-to-merge`