Closed KalleEdstroem closed 1 year ago
@BHoMBot check copyright-compliance @BHoMBot check documentation-compliance @BHoMBot check project-compliance
@BHoMBot check copyright-compliance @BHoMBot check documentation-compliance @BHoMBot check project-compliance
@BHoMBot check copyright-compliance @BHoMBot check documentation-compliance @BHoMBot check project-compliance
@BHoMBot check versioning @BHoMBot check serialisation @BHoMBot check null-handling @BHoMBot check installer @BHoMBot check core
@BHoMBot check ready-to-merge
@BHoMBot check required @BHoMBot check copyright-compliance @BHoMBot check ready-to-merge
@BHoMBot check ready-to-merge
Issues addressed by this PR
The change makes the
MidasCivilAdapter
more consistent with other adapters. It makes it functioning with theBHoMAdapter create
method.Closes #354
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/MidasCivil_Toolkit/%23354-ModifyingAdapterToIncludeAdapterSettings?csf=1&web=1&e=5LpPet
Changelog
MidasCivilAdapterSettings
Including a stringVersion
.Create
class
.MidasCivilAdapter
. -version
+MidasCivilAdapterSettings
.version
is read from theMidasCivilAdapterSettings
.Additional comments
For testing of versioning it is needed to build the
Versioning_Toolkit
after building thisbranch
.