BHoM / Mongo_Toolkit

GNU Lesser General Public License v3.0
2 stars 3 forks source link

Change default PushType; remove MongoConfig and rely on Push inputs #151

Closed alelom closed 3 years ago

alelom commented 3 years ago

Issues addressed by this PR

Closes #93 Closes #150

The default Push behaviour is now to "append", while you need to set the PushType to DeleteThenCreate to "replace". The MongoConfig has been deleted, as it's redundant.

Test files

Try any existing script, e.g. https://burohappold.sharepoint.com/:f:/s/BHoM/ElPtUXgB2_pEvRhg7WfRuvEBlaP93pGBZ_zPeWvWpTYtYQ?e=X8HQEI

Changelog

alelom commented 3 years ago

@BHoMBot check required

bhombot-ci[bot] commented 3 years ago
@alelom to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `core` - `null-handling` - `serialisation` - `installer` - `versioning`
alelom commented 3 years ago

@BHoMBot check required

bhombot-ci[bot] commented 3 years ago
@alelom to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `core` - `null-handling` - `serialisation` - `installer` - `versioning` There are 12 requests in the queue ahead of you.
alelom commented 3 years ago

@BHoMBot check required @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 3 years ago
@alelom to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `core` - `null-handling` - `serialisation` - `installer` - `versioning` - `ready-to-merge`
alelom commented 3 years ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 3 years ago
@alelom to confirm, the following checks are now queued: - `copyright-compliance` - `dataset-compliance` - `ready-to-merge`
bhombot-ci[bot] commented 3 years ago
The check `ready-to-merge` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 3 years ago

Having discussed with @alelom and am merging to continue testing via alphas over the weekend/early next week. Things we want to ensure are still working with this update will include analytics scraping, bot operations, and other existing uses of Mongo Toolkit in operation. FYI @adecler @michaelhoehn @IsakNaslundBh