BHoM / OpenStreetMap_Toolkit

Tools for working with OpenStreetMap
GNU Lesser General Public License v3.0
4 stars 2 forks source link

Add missing references to Dimensional_oM #85

Closed IsakNaslundBh closed 1 year ago

IsakNaslundBh commented 1 year ago

NOTE: Depends on

Done in support of https://github.com/BHoM/BHoM/pull/1393/checks?check_run_id=8590783659

Issues addressed by this PR

Adding missing references to Dimensional_oM to make sure the toolkit compiles.

Test files

Changelog

Additional comments

IsakNaslundBh commented 1 year ago

@BHoMBot check project compliance

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to do? For a list of available instructions, please see [this wiki page](https://github.com/BHoM/documentation/wiki/Continuous-Integration).
IsakNaslundBh commented 1 year ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `project-compliance` There are 11 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `8594103278`
IsakNaslundBh commented 1 year ago

@BHoMBot fix project file ref. 8594103278

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh I have queued up your request to fix the `csproj` file(s). There are 0 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh I am now going to fix the project compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.
IsakNaslundBh commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 31 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check core

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `core`
FraserGreenroyd commented 1 year ago

@BHoMBot this is a DevOps instruction. I am requesting a force check on: core

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.
bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have provided force checks to the checks requested.
FraserGreenroyd commented 1 year ago

@BHoMBot check versioning

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning`
FraserGreenroyd commented 1 year ago

@BHoMBot check installer

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `installer`
IsakNaslundBh commented 1 year ago

@BHoMBot check serialisation @BHoMBot check null-handling @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `serialisation` - check `null-handling` - check `ready-to-merge` There are 4 requests in the queue ahead of you.