BHoM / Python_Toolkit

GNU Lesser General Public License v3.0
3 stars 2 forks source link

Python virtual environment creation fixes and refactor #107

Closed tg359 closed 1 year ago

tg359 commented 1 year ago

Issues addressed by this PR

Closes #106

As of 2023-08-03 this code certainly requires a bunch of versioning stuff added (as well as old code re-included) in order to appease the bot. This message will be removed once that's been done but I wanted to raise this now in WIP to stop me from forgetting.

Changes should mean that reinstallation of an environment completely removes the old one in order to "start fresh" and avoid conflicts, plus methods of querying existing environments are a lot faster.

Test files

Changelog

Additional comments

jamesramsden-bh commented 1 year ago

@BHoMBot check required

jamesramsden-bh commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 19 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `15713802954`
jamesramsden-bh commented 1 year ago

@BHoMBot fix project file ref. 15713802954

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh I have queued up your request to fix the `csproj` file(s). There are 0 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh I'm sorry, but I cannot take that instruction from you. As this action would modify this Pull Request, this instruction can only come via an authorised user, per our [Code of Conduct for Bots](https://github.com/BHoM/BHoM/blob/main/docs/CODE_OF_CONDUCT_FOR_BOTS.md)
FraserGreenroyd commented 1 year ago

@BHoMBot fix project file ref. 15713802954

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have queued up your request to fix the `csproj` file(s). There are 0 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.
jamesramsden-bh commented 1 year ago

@BHoMBot check versioning

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `versioning`
jamesramsden-bh commented 1 year ago

@BHoMBot check versioning

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `versioning`
jamesramsden-bh commented 1 year ago

@BHoMBot check versioning

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `versioning`
jamesramsden-bh commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 24 requests in the queue ahead of you.
jamesramsden-bh commented 1 year ago

@BHoMBot check code-compliance

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `code-compliance` There are 43 requests in the queue ahead of you.
jamesramsden-bh commented 1 year ago

@BHoMBot check code-compliance

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `code-compliance`
jamesramsden-bh commented 1 year ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `copyright-compliance`
jamesramsden-bh commented 1 year ago

@BHoMBot check code-compliance

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `code-compliance`
jamesramsden-bh commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 1 year ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 1 year ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
FraserGreenroyd commented 1 year ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `copyright-compliance` There are 10 requests in the queue ahead of you.