Closed Tom-Kingstone closed 1 week ago
@BHoMBot check versioning
@BHoMBot check versioning
@BHoMBot check versioning
@BHoMBot check versioning
@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot check core @BHoMBot check compliance
@BHoMBot check serialisation @BHoMBot check null-handling
@BHoMBot check code-compliance
@BHoMBot check installer
@BHoMBot check core @BHoMBot check compliance
@BHoMBot check versioning
@BHoMBot check versioning @BHoMBot check installer
@BHoMBot check versioning @BHoMBot check compliance
@BHoMBot check installer
@BHoMBot check core @BHoMBot check null-handling @BHoMBot check serialisation
@BHoMBot check core @BHoMBot check compliance
@BHoMBot check installer @BHoMBot check versioning
@BHoMBot check null-handling @BHoMBot check serialisation
@jamesramsden-bh suggested that the error should also display which base environments are currently installed (if any) as well as clearly stating that the one requested isn't installed.
@BHoMBot check installer
@BHoMBot check installer -force
@BHoMBot check installer
@BHoMBot check required
@BHoMBot check required
NOTE: Depends on
Issues addressed by this PR
Closes #142
The changes in this PR necessitate changes to the following downstream repositories:
Refactor of very core methods, so this PR requires extensive testing, with any python based unit tests and the beta testing procedures.
Updated the base python environment logic to use the windows installer instead of embedded packages (which allows tkinter and other similar libraries to be included), and updated the Remove methods respectively to use the installer to remove the environment (as the windows installer modifies the registry to keep track of the version).
Updated relevant enums and dictionaries to only allow the most recent specific version of each minor python version, as the windows installer does not support having more than one specific version downloaded at the same time.
Move the bhom analytics logger from LadybugTools_Toolkit to Python_Toolkit (as this is where it should be to be accessible to all python based toolkits)
Test files
Use the beta test procedure and any supporting unit tests for this repo and any downstream repositories
Changelog
Additional comments
When testing, make sure that if you wish to remove an environment, use the methods that remove the environments rather than manually deleting the folder, as removing the folder will not update any registry keys and therefore make it impossible to install that version of python again (this is a limitation of the windows installer). If you accidentally do this, contact me for help to resolve the issue.