BHoM / Python_Toolkit

GNU Lesser General Public License v3.0
4 stars 2 forks source link

Move base plots from LadybugTools_Toolkit #147

Open Tom-Kingstone opened 2 days ago

Tom-Kingstone commented 2 days ago

NOTE: Depends on

Issues addressed by this PR

Closes #141

Moved all base plots that don't reference any pollination-based packages to Python_Toolkit, as well as helper and utility methods.

Also updated the .gitignore to align better with LBT_TK

Test files

Use the unit tests in Python_Toolkit and LadybugTools_Toolkit, as there should be no change to method signatures or functionality in LBT (see the PR in LadybugTools_Toolkit)

Changelog

Additional comments

Tom-Kingstone commented 2 days ago

@BHoMBot check installer

bhombot-ci[bot] commented 2 days ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `installer`
Tom-Kingstone commented 2 days ago

@BHoMBot check installer

bhombot-ci[bot] commented 2 days ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `installer`
Tom-Kingstone commented 1 day ago

@BHoMBot check installer @BHoMBot check versioning

bhombot-ci[bot] commented 1 day ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `installer` - check `versioning` There are 16 requests in the queue ahead of you.
Tom-Kingstone commented 1 day ago

@BHoMBot check installer

bhombot-ci[bot] commented 1 day ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `installer` There are 29 requests in the queue ahead of you.
Tom-Kingstone commented 1 day ago

wrong PR 🤦

bhombot-ci[bot] commented 1 day ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
Tom-Kingstone commented 1 day ago

@BHoMBot check core @BHoMBot check compliance

bhombot-ci[bot] commented 1 day ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `core` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 10 requests in the queue ahead of you.
Tom-Kingstone commented 1 day ago

@BHoMBot check null-handling @BHoMBot check serialisation

bhombot-ci[bot] commented 1 day ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `null-handling` - check `serialisation` There are 43 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 day ago
@Tom-Kingstone just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on LadybugTools_Toolkit