Area loads working, database opening and closing glitching fixed

BHoM / RAM_Toolkit

GNU Lesser General Public License v3.0

5 stars 0 forks source link

Closed enarhi closed 4 years ago

enarhi commented 5 years ago

Closes #91 (fully) Closes #51 Closes #107

Added support for reading and creating area loads
Fixed Read/Toggle/Read glitch caused by API calls and database handling
Additional notes

JosefTaylor commented 5 years ago

Added open/close database in the push/pull override. @enarhi back to you!

enarhi commented 5 years ago

This one is ready to go. @JosefTaylor please review with my latest commits to ensure full functionality with new database handling. Updated test script to test model read/create roundtripping at: https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/RAM_Toolkit/Issue91%20Area%20Loads?csf=1&e=UfT5Tu

JosefTaylor commented 4 years ago

Looks like read ContourLoadSet is failing, which can cause the pull to fail, and that causes the database not to close.

JosefTaylor commented 4 years ago

Wrapping the pull/push keeps the wheels on, however pull ContourLoadSet still fails.

JosefTaylor commented 4 years ago

This should do it @enarhi, tested with my models.