Improve error handling to indicate cause of error and if overall push worked or not, especially with "Cannot distribute outlines error" for panel pushes #212
Currently an opaque error is returned if pushing, and then trying to push again. This error is due to the inability to do a repeated push in this way, and should be handled with a reported error accordingly. We should also have clear error handling for floors, as they currently report an error when the DistributeOutlines method fails for the collection of floors on a single story. When this occurs, the fragment setting can also fail, throwing a similarly opaque error that implies the push failed when all other elements actually still pushed correctly.
Steps to reproduce:
Toggle push to true, false, and true again when pushing levels and other elements. Our standard structural test script includes floors that trigger the distribute outlines failure described above as well, which then returns the mentioned opaque error.
Expected behaviour:
Errors clearly indicating what went wrong, and what still worked, along with info needed to resolve the error.
Description:
Currently an opaque error is returned if pushing, and then trying to push again. This error is due to the inability to do a repeated push in this way, and should be handled with a reported error accordingly. We should also have clear error handling for floors, as they currently report an error when the
DistributeOutlinesmethod fails for the collection of floors on a single story. When this occurs, the fragment setting can also fail, throwing a similarly opaque error that implies the push failed when all other elements actually still pushed correctly.Steps to reproduce:
Toggle push to true, false, and true again when pushing levels and other elements. Our standard structural test script includes floors that trigger the distribute outlines failure described above as well, which then returns the mentioned opaque error.
Expected behaviour:
Errors clearly indicating what went wrong, and what still worked, along with info needed to resolve the error.
Test file(s):
Structural base push test script.