BHoM / RAM_Toolkit

GNU Lesser General Public License v3.0
5 stars 0 forks source link

6.1 Deployment #214

Closed bhombot-ci[bot] closed 1 year ago

bhombot-ci[bot] commented 1 year ago

RAM_Toolkit

Feature

FraserGreenroyd commented 1 year ago

@BHoMBot check beta-merge-status

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `beta-merge-status` There are 59 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check beta-merge-status

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `beta-merge-status` There are 59 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
MERGE REPORT - 2023-03-19 15:19. DETAILS: This pull request can be merged or not merged without impact on any of its upstream dependencies..
LukeBastianBH commented 1 year ago

I followed the Structural Adapters Test Procedure document.

I was unable to push or update anything except for levels (throws the following error): "1. This component failed to run properly.

  • Error: Value cannot be null. Parameter name: key
  • Occured in BH.Adapter.BHoMAdapter.GetCachedOrReadAsDictionary[TId,TObj](IList ids, ActionConfig actionConfig) called from BH.Adapter.BHoMAdapter.GetCachedOrRead[T](IList ids, String tag, ActionConfig actionConfig)
  • Are you sure you have the correct type of inputs? Check their description for more details." image

Also, just wanted to flag that results can't currently be read out of RAM. If the object requested in the pull component is a ResultRequest, an error similar to "ReadResults for BarResultRequest is not implemented in RAMAdapter." is given. If another result type is directly requested, an error similar to this is given: "BarStress cannot be extracted using a FilterRequest. Please instead make use of the BarResultRequest that gives more options for the result extraction." image

The error above when pushing has been fixed, but now there is a new error when pushing loads to both bars and areas. "1. This component failed to run properly.

Besides that and the comment on outputting results - everything else is looking good.

FraserGreenroyd commented 1 year ago

Owing to a lack of reviews signing off this repository for all of the changes proposed to this beta, I am unable to deploy this pull request to the 6.1 beta.

If there is sufficient demand, we may be able to look at doing a 6.1 beta patch and include it prior to the 6.2 beta.

I am closing this pull request to tidy up and complete the 6.1 deployment. The work will not be lost, and will be eligible for inclusion in the 6.2 beta if it is not deployed via a beta patch prior to the 6.2 beta.

FraserGreenroyd commented 1 year ago

Have discussed with @enarhi who was testing this through as it was closed - he requires another 10-15 minutes which I am providing owing to this pull request not being dependent on any of the higher dependency repositories which are unable to deploy.

FraserGreenroyd commented 1 year ago

@BHoMBot check beta-merge-status

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `beta-merge-status`
bhombot-ci[bot] commented 1 year ago
MERGE REPORT - 2023-03-22 15:12. ERROR CODE(s): - DF001. DETAILS: - This pull request can NOT be merged without one or more of its upstream dependencies being merged. Merging this pull request without dependencies will cause compilation errors in this repository. See the check annotations for more information..
FraserGreenroyd commented 1 year ago

While this pull request contains a sufficient review from the toolkit lead @enarhi, unfortunately it is blocked by the inability to deploy one or more of the repositories higher up in this repositories dependency chain.

If there is sufficient demand, we may be able to look at doing a 6.1 beta patch and include it prior to the 6.2 beta.

I am closing this pull request to tidy up and complete the 6.1 deployment. The work will not be lost, and will be eligible for inclusion in the 6.2 beta if it is not deployed via a beta patch prior to the 6.2 beta.

bhombot-ci[bot] commented 1 year ago
@bhombot-ci[bot] just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM
bhombot-ci[bot] commented 1 year ago
@bhombot-ci[bot] just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM
FraserGreenroyd commented 1 year ago

@BHoMBot check compliance @BHoMBot check null-handling @BHoMBot check serialisation @BHoMBot check core

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `null-handling` - check `serialisation` - check `core` There are 117 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@bhombot-ci[bot] just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Revit_Toolkit
bhombot-ci[bot] commented 1 year ago
@bhombot-ci[bot] just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Revit_Toolkit
FraserGreenroyd commented 1 year ago

@BHoMBot check dataset-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `dataset-compliance` There are 6 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 20 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.