Closed bhombot-ci[bot] closed 1 year ago
@BHoMBot check beta-merge-status
@BHoMBot check beta-merge-status
I followed the Structural Adapters Test Procedure document.
I was unable to push or update anything except for levels (throws the following error): "1. This component failed to run properly.
- Error: Value cannot be null. Parameter name: key
- Occured in BH.Adapter.BHoMAdapter.GetCachedOrReadAsDictionary[TId,TObj](IList ids, ActionConfig actionConfig) called from BH.Adapter.BHoMAdapter.GetCachedOrRead[T](IList ids, String tag, ActionConfig actionConfig)
- Are you sure you have the correct type of inputs? Check their description for more details."
Also, just wanted to flag that results can't currently be read out of RAM. If the object requested in the pull component is a ResultRequest, an error similar to "ReadResults for BarResultRequest is not implemented in RAMAdapter." is given. If another result type is directly requested, an error similar to this is given: "BarStress cannot be extracted using a FilterRequest. Please instead make use of the BarResultRequest that gives more options for the result extraction."
The error above when pushing has been fixed, but now there is a new error when pushing loads to both bars and areas. "1. This component failed to run properly.
1 objects, ActionConfig actionConfig) called from BH.Adapter.BHoMAdapter.FullCRUD[T](IEnumerable
1 objectsToPush, PushType pushType, String tag, ActionConfig actionConfig)Besides that and the comment on outputting results - everything else is looking good.
Owing to a lack of reviews signing off this repository for all of the changes proposed to this beta, I am unable to deploy this pull request to the 6.1 beta.
If there is sufficient demand, we may be able to look at doing a 6.1 beta patch and include it prior to the 6.2 beta.
I am closing this pull request to tidy up and complete the 6.1 deployment. The work will not be lost, and will be eligible for inclusion in the 6.2 beta if it is not deployed via a beta patch prior to the 6.2 beta.
Have discussed with @enarhi who was testing this through as it was closed - he requires another 10-15 minutes which I am providing owing to this pull request not being dependent on any of the higher dependency repositories which are unable to deploy.
@BHoMBot check beta-merge-status
While this pull request contains a sufficient review from the toolkit lead @enarhi, unfortunately it is blocked by the inability to deploy one or more of the repositories higher up in this repositories dependency chain.
If there is sufficient demand, we may be able to look at doing a 6.1 beta patch and include it prior to the 6.2 beta.
I am closing this pull request to tidy up and complete the 6.1 deployment. The work will not be lost, and will be eligible for inclusion in the 6.2 beta if it is not deployed via a beta patch prior to the 6.2 beta.
@BHoMBot check compliance @BHoMBot check null-handling @BHoMBot check serialisation @BHoMBot check core
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge
RAM_Toolkit
Feature
Compliance