search

BHoM / RDF_Prototypes

Research project of the Cluster of Excellence "Integrative Computational Design and Construction for Architecture" (IntCDC) https://www.intcdc.uni-stuttgart.de/ **Project Name**: Knowledge Representation for Multi-Disciplinary Co-Design of Buildings. https://www.intcdc.uni-stuttgart.de/research/research-projects/rp-20/
GNU Lesser General Public License v3.0
9 stars 4 forks source link

Do geometries need to have another way of assigning IDs/URIs? Currently two identical points are recognized as the same one #40

Closed DiellzaElshani closed 2 years ago

DiellzaElshani commented 2 years ago

Currently geometries use the HashCode to get an URI in the TLL format. However, when two identical points are input to the graph, they are not recognized as two points, but as one. I understand that BHoM does not assign GUID to geometries, to handle complex geometries more efficiently. But this might bring some problems in the RDF graph representation.

image

Steps to reproduce:

I am not sure if that is a problem, maybe not. However, if yes: I suggest having another way to generate the URI (rather than the hashcode). An way to approach this can be to: whenever we use geometry as input, always use a custom object where we also add a label (user input ID, or something similar); from where we generate a static, unique GUID (or we use the Custom Objects ID to refer to the geometry).

image

Expected behaviour:

Test file(s):

alelom commented 2 years ago

Please see my reply https://github.com/BHoM/RDF_Prototypes/issues/41#issuecomment-1176311237.

DiellzaElshani commented 2 years ago

As suggested on your https://github.com/BHoM/RDF_Prototypes/issues/41#issuecomment-1176311237, we should switch to using the static hash.