DiellzaElshani
commented
1 year ago I checked last weeks output, accordingly I suggest:
Ontology Settings: The text section on ontology settings seems redundant, because: title, description and base address can be found in the highlighted lines.
TBox Settings:
the main input of the component is the CustomObjectTypesBaseAddress. Could we not print this line in text and read it directly from the URI of a Custom Object Class?
The rest of the input is set by default if we don't change or give some other information. Can we check if the component uses default values first; if yes: don't print the text; (output TBoxSettings by only using the CustomObjectTypesBaseAddress input, and give the default data for the rest); if the input data is not default: print it with a # as Aaron did it.
ABoxSettings: Similar with TBox; Can read the IndividualsBaseAddress from the individuals URI?
For the other two: Check if the input is default, if yes, don’t print the text. (Recreate the component using default values) In case the input is not default print it with the #
Description:
The current ReadTTL component return all BHoM objects from the generated ontology. However, to generate the graph/ontology, initially, beside bhom objects, we input also: (1) ontologySettings and (2) localRepositorySettings. It would be more efficient if ReadTTL component returns also these two. While (2) localRepositorySettings is arguable (I don't see a reason why we need it or not); returning (1)ontologySettings is crucial.
Bottomline, ReadTTL should return (1) ontologySettings as well. Please share thoughts or comments.