BHoM / Revit_Toolkit

A set of tools enabling exchange of information between BHoM and Revit.
GNU Lesser General Public License v3.0
27 stars 13 forks source link

Support for Revit 2018 and 2019 removed #1413

Closed pawelbaran closed 11 months ago

pawelbaran commented 11 months ago

Issues addressed by this PR

Closes #1412

Test files

Standard test procedure.

Changelog

Additional comments

The scope of this PR, although limited, touches quite a lot of files on different levels - please review the changes carefully to avoid us sneaking in any bugs that could hit us at the end of the milestone 👍

pawelbaran commented 11 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 11 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
pawelbaran commented 11 months ago

@BHoMBot check core

bhombot-ci[bot] commented 11 months ago
@pawelbaran to confirm, the following actions are now queued: - check `core` There are 57 requests in the queue ahead of you.
pawelbaran commented 11 months ago

@FraserGreenroyd am I correct we need to tweak the bot/installer to make the check pass?

pawelbaran commented 11 months ago

@BHoMBot check core

bhombot-ci[bot] commented 11 months ago
@pawelbaran to confirm, the following actions are now queued: - check `core`
FraserGreenroyd commented 11 months ago

@FraserGreenroyd am I correct we need to tweak the bot/installer to make the check pass?

Sorry @pawelbaran only just caught up with things.

You are correct though as I think you've found on the altConfigs for this repo for core. We also need to update the bot installer as well but we can do that once we're fully happy with this.

FraserGreenroyd commented 11 months ago

@BHoMBot check installer

bhombot-ci[bot] commented 11 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `installer`
FraserGreenroyd commented 11 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 11 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning`
bhombot-ci[bot] commented 11 months ago
@pawelbaran just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit
bhombot-ci[bot] commented 11 months ago
@pawelbaran just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit
pawelbaran commented 11 months ago

@BHoMBot check compliance @BHoMBot check serialisation @BHoMBot check null-handling

bhombot-ci[bot] commented 11 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `serialisation` - check `null-handling` There are 9 requests in the queue ahead of you.
FraserGreenroyd commented 11 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

bhombot-ci[bot] commented 11 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.