search

BHoM / Revit_Toolkit

A set of tools enabling exchange of information between BHoM and Revit.
GNU Lesser General Public License v3.0
28 stars 13 forks source link

`Query.Bounds` - add overload for collection of bounding boxes, `DoesIntesect` - add transform input #1445

Closed michal-pekacki closed 9 months ago

michal-pekacki commented 9 months ago

NOTE: Depends on

Issues addressed by this PR

Closes #

Breaking change in DoesIntersect(BoundingBoxXYZ, Element) method - element transform calculation has been removed from the body as it can produce incorrect results. Transform of element has been added as an input.

Test files

Changelog

Additional comments

pawelbaran commented 9 months ago

@BHoMBot check compliance @BHoMBot check core @BHoMBot check null-handling @BHoMBot check serialisation

bhombot-ci[bot] commented 9 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `core` - check `null-handling` - check `serialisation` There are 12 requests in the queue ahead of you.
bhombot-ci[bot] commented 9 months ago
@michal-pekacki just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on BHoM_Engine
michal-pekacki commented 9 months ago

@BHoMBot check required

bhombot-ci[bot] commented 9 months ago
@michal-pekacki to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 17 requests in the queue ahead of you.
bhombot-ci[bot] commented 9 months ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
michal-pekacki commented 9 months ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance

bhombot-ci[bot] commented 9 months ago
@michal-pekacki to confirm, the following actions are now queued: - check `copyright-compliance` - check `dataset-compliance`
bhombot-ci[bot] commented 9 months ago
@michal-pekacki just to let you know, I have provided a `check-ready-to-merge` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine