Closed vietle-bh closed 5 months ago
@vietle-bh I believe it would be good to have test files for such discrete bugs. It should be relatively quick to copy-paste the failing element to an empty document, then create a simple pull script that would highlight the failure - happy to help you out with the latter once you have the file with isolated element ready 👍
@BHoMBot check required
@BHoMBot check dataset-compliance @BHoMBot check copyright-compliance @BHoMBot check ready-to-merge
Issues addressed by this PR
Closes #1462
If externalLoop is null for any reason, we'll fall back on find the loop with the max area. This is slower than checking loop winding direction, but externalLoop is null in like 1 out of 1000 faces, so the performance hit isn't bad.
Test files
@pawelbaran : Do we need a test file for this PR?
Changelog
Additional comments