BHoM / Revit_Toolkit

A set of tools enabling exchange of information between BHoM and Revit.
GNU Lesser General Public License v3.0
27 stars 13 forks source link

Facade converts revamped #1470

Closed pawelbaran closed 4 months ago

pawelbaran commented 5 months ago

Issues addressed by this PR

Closes #1459

Test files

Standard facade pull test procedure + whatever you find relevant @enarhi. In general, the output should be the same or better, where better means:

Changelog

Additional comments

pawelbaran commented 4 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
pawelbaran commented 4 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
pawelbaran commented 4 months ago

@BHoMBot check required

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 4 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 4 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
pawelbaran commented 4 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `versioning` There are 11 requests in the queue ahead of you.
pawelbaran commented 4 months ago

@BHoMBot check compliance @BHoMBot check core @BHoMBot check serialisation @BHoMBot check null-handling @BHoMBot check installer

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `core` - check `serialisation` - check `null-handling` - check `installer`
pawelbaran commented 4 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge` There are 2 requests in the queue ahead of you.
bhombot-ci[bot] commented 4 months ago
@pawelbaran just to let you know, I have provided a `check-ready-to-merge` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
bhombot-ci[bot] commented 4 months ago
The check `ready-to-merge` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 4 months ago
@pawelbaran just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
bhombot-ci[bot] commented 4 months ago
@pawelbaran just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
bhombot-ci[bot] commented 4 months ago
@pawelbaran just to let you know, I have provided a `check-ready-to-merge` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine