search

BHoM / Revit_Toolkit

A set of tools enabling exchange of information between BHoM and Revit.
GNU Lesser General Public License v3.0
27 stars 13 forks source link

Issues with pulling from links in case of one document being linked multiple times #1477

Closed pawelbaran closed 3 months ago

pawelbaran commented 3 months ago

Description:

The issue occurs when a given document is linked multiple times, in either of scenarios:

Currently none of the above is handled properly, which could probably be solved by tweaking requestsByLinks to work with RevitLinkInstance rather than Document: https://github.com/BHoM/Revit_Toolkit/blob/4bea6f1dd3b939af1df433abd1f1e72146c43e8a/Revit_Core_Adapter/CRUD/Read.cs#L90-L103

enarhi commented 3 months ago

Adding that I have also seen this occur due to an Architect's link containing self reference to other architect links, and improperly saved so that those nested links are forced to appear when we link it without the option to not include nested links. This can be treated similarly to the first case you've listed.