Issues with pulling from links fixed

BHoM / Revit_Toolkit

A set of tools enabling exchange of information between BHoM and Revit.

GNU Lesser General Public License v3.0

27 stars 13 forks source link

Issues with pulling from links fixed #1486

Closed pawelbaran closed 3 months ago

pawelbaran commented 3 months ago

Issues addressed by this PR

Closes #1477

Test files

This is quite a substantial change to the adapter mechanics, so thorough testing is required. Following tests to be done:

[ ] PR-specific test script available here (@enarhi) - mirrored links require https://github.com/BHoM/BHoM_Engine/pull/3356 to come through (but this is out of scope of this PR)
[ ] @enarhi please test against your project issue that originated #1477
[x] unit tests for Pull (@michal-pekacki please check this PR against the most recent work of yours)
[x] standard procedure for pulling from links (files are available here) - would be great if you could confirm everything is still OK @michal-pekacki

Changelog

Additional comments

pawelbaran commented 3 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 3 months ago

@pawelbaran to confirm, the following actions are now queued: - check `versioning` There are 19 requests in the queue ahead of you.

pawelbaran commented 3 months ago

Apologies @enarhi, I forgot to mention that the mirrored links require https://github.com/BHoM/BHoM_Engine/pull/3356 to be built locally - updated the PR description now. Meanwhile, I think we can tell the tests went positive on your end, the only issue originating from the missing information about the need to build a specific BHoM_Engine branch. Thanks!

pawelbaran commented 3 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 3 months ago

@pawelbaran to confirm, the following actions are now queued: - check `versioning` There are 38 requests in the queue ahead of you.

pawelbaran commented 3 months ago

@BHoMBot check required

bhombot-ci[bot] commented 3 months ago

@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 50 requests in the queue ahead of you.

bhombot-ci[bot] commented 3 months ago

The check `versioning` has already been run previously and recorded as a successful check. This check has not been run again at this time.

pawelbaran commented 3 months ago

@BHoMBot check installer

bhombot-ci[bot] commented 3 months ago

@pawelbaran to confirm, the following actions are now queued: - check `installer`

pawelbaran commented 3 months ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance

bhombot-ci[bot] commented 3 months ago

@pawelbaran to confirm, the following actions are now queued: - check `copyright-compliance` - check `dataset-compliance` There are 1 requests in the queue ahead of you.

pawelbaran commented 3 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 3 months ago

@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge`