BHoM / Revit_Toolkit

A set of tools enabling exchange of information between BHoM and Revit.
GNU Lesser General Public License v3.0
27 stars 13 forks source link

Extract the external curve loop query to its own method #1497

Closed vietle-bh closed 1 month ago

vietle-bh commented 1 month ago

NOTE: Depends on

Issues addressed by this PR

Closes #1496

Extracted the external curve loop query to its own method

Test files

I simply cut & pasted the relevant code to a new file, so hopefully just code review will be enough!

Changelog

Additional comments

vietle-bh commented 1 month ago

@BHoMBot check compliance @BHoMBot check core @BHoMBot check null-handling @BHoMBot check serialisation @BHoMBot check project-compliance @BHoMBot check versioning @BHoMBot check installer

bhombot-ci[bot] commented 1 month ago
@vietle-bh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `core` - check `null-handling` - check `serialisation` - check `project-compliance` - check `versioning` - check `installer` There are 8 requests in the queue ahead of you.
vietle-bh commented 1 month ago

@BHoMBot check versioning @BHoMBot check installer

bhombot-ci[bot] commented 1 month ago
@vietle-bh to confirm, the following actions are now queued: - check `versioning` - check `installer` There are 11 requests in the queue ahead of you.
vietle-bh commented 1 month ago

@BHoMBot check versioning @BHoMBot check installer

bhombot-ci[bot] commented 1 month ago
@vietle-bh to confirm, the following actions are now queued: - check `versioning` - check `installer` There are 14 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 month ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 month ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
pawelbaran commented 1 month ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge` There are 59 requests in the queue ahead of you.