BHoM / Revit_Toolkit

A set of tools enabling exchange of information between BHoM and Revit.
GNU Lesser General Public License v3.0
27 stars 13 forks source link

Fix PlanarSurface conversion bug #1500

Closed vietle-bh closed 1 month ago

vietle-bh commented 1 month ago

NOTE: Depends on

Issues addressed by this PR

Closes #1499

Instead of comparing objects, we can detect internal openings by their bounding boxes, which should be always smaller than the main external boundary's bounding box.

2024 loops fixed

Test files

TBC

Changelog

Additional comments

pawelbaran commented 1 month ago

Instead of comparing objects, we can detect internal openings by their loop length, which is always shorter than the main external boundary.

Are you sure? 😉 image

vietle-bh commented 1 month ago

@pawelbaran : Not anymore! I've changed to comparing bounding boxes instead. Please check again 🥂

pawelbaran commented 1 month ago

@BHoMBot check required

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
vietle-bh commented 1 month ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 month ago
@vietle-bh to confirm, the following actions are now queued: - check `copyright-compliance` - check `dataset-compliance` - check `ready-to-merge`
pawelbaran commented 1 month ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge`