Closed pawelbaran closed 4 years ago
I updated the content of this issue following the discussion in #385 - @adecler @alelom @al-fisher could you please have a look and flag up if there is any inconsistency in here? If not, I will action this in the current milestone.
Great to see a good summary like this! Agree 100%:
EventHandlers
/ AdapterAction
change.I agree that the current project names and namespaces need to be improved. But I am not sure I like the proposed solution as it is not compliant. For example, a project should always end with either oM, Engine, Adapter, or UI. This is not just to make it easier for people to find their way around the code structure but also to enable automated processes.
As always, Revit is a more complicated beast so it might be worth having a proper meeting around this to see if (and how) we need to extend our conventions or if we can obtain clarity with the existing one.
Bumping to 3.2 due to BHoM_UI #223
THIS ISSUE IS A FOLLOW-UP FROM #385
Description:
Assemblies and namespaces sitting in Revit_UI folder to be reshuffled in order to make them more informative. My proposal (discussed to some extent with @al-fisher and @IsakNaslundBh) presented below.
Project renaming:
Namespace renaming:
BH.UI.Revit
- to be renamed toBH.UI.Revit.Listener
BH.Adapter.Revit
- to stay untouchedBH.UI.Revit.Adapter
- to be renamed toBH.Adapter.Revit.Plugin
BH.oM.Adapters.Revit
- to be renamed toBH.oM.External.Revit
BH.Engine.Adapters.Revit
- to be renamed toBH.Engine.External.Revit
BH.UI.Revit.Engine
- to be renamed toBH.Engine.External.RevitAPI
BH.oM.Adapters.Revit.Interface
- Interface suffix to be removed, aligned as aboveClass renaming:
RevitUIAdapter
- to be renamed toRevitAdapterPlugin
Folder and file renaming:
What do you guys think? Any big no from anyone?