search

BHoM / Revit_Toolkit

A set of tools enabling exchange of information between BHoM and Revit.
GNU Lesser General Public License v3.0
27 stars 13 forks source link

Revit_Toolkit: Adapt to changes to PlanarSurface #722

Closed kThorsager closed 4 years ago

kThorsager commented 4 years ago

Again

Parent issue(s) or Pull Request(s) causing the changes:

https://github.com/BHoM/BHoM/issues/877 We made PlanarSurface IImmutable poorly, which will have to be resolved.

Description:

c:\github\revit_toolkit\engine_revit_ui\query\planarsurfacedictionary.cs uses the Internal Openings List as a list, which isn't possible after we switch toReadOnlyCollection. and since it uses it by reference I'm vary of trying to fix it myself.

Test file(s):

Not broken yet

pawelbaran commented 4 years ago

@kThorsager I just had a look at that - seems to be a bit tricky and I would prefer not to change it now, out of nowhere. However, I am planning to refactor this method in this Milestone, so happy to take on that later in June. Would it be OK to freeze the refactoring of PlanarSurface until then?

kThorsager commented 4 years ago

Yes, I think this way of treating it should be unusual enough that it isn't pressing enough to mess up Revit_Toolkit 👍

al-fisher commented 4 years ago

Agreed - sounds like a fine plan

pawelbaran commented 4 years ago

Bumping to 3.3 as it seems not to be the right moment to implement that change.