Revit_Toolkit: refactor BH.Revit.Engine.Core.Query.DuctShape method to work on shape properties instead of strings

BHoM / Revit_Toolkit

A set of tools enabling exchange of information between BHoM and Revit.

GNU Lesser General Public License v3.0

28 stars 13 forks source link

Revit_Toolkit: refactor BH.Revit.Engine.Core.Query.DuctShape method to work on shape properties instead of strings #842

Closed pawelbaran closed 4 years ago

pawelbaran commented 4 years ago

Description:

As discussed on the review of https://github.com/BHoM/Revit_Toolkit/pull/833, DuctShape query should not base its logic on family name string, but rather on DuctType.Shape property for Revit 2019 and above and Connector.Shape of one of the end connectors for Revit 2018.

pawelbaran commented 4 years ago

Fixed with #847.