search

BHoM / Revit_Toolkit

A set of tools enabling exchange of information between BHoM and Revit.
GNU Lesser General Public License v3.0
27 stars 13 forks source link

Revit_Toolkit: Unit conversion bug in MEP converts #845

Closed pawelbaran closed 3 years ago

pawelbaran commented 4 years ago

Description:

LookupParameterDouble by default involves unit conversion to SI. Therefore, any time an explicit convert to SI is implemented in MEP converts, the units will be converted twice, resulting in wrong values, e.g. here: https://github.com/BHoM/Revit_Toolkit/blob/f7507830f1bdf7336702851bd0ee39d53fcb6c6b/Revit_Core_Engine/Query/PipeSectionProperty.cs#L52

Whole code base added in #833 needs to be inspected with this regard.

FYI @FraserGreenroyd @kayleighhoude

pawelbaran commented 3 years ago

Fixed with #847.