Brep not attaching to custom object as expected

BHoM / Rhinoceros_Toolkit

Set of functionalities for communication with Rhinoceros

GNU Lesser General Public License v3.0

6 stars 2 forks source link

Brep not attaching to custom object as expected #168

Closed harrilewis closed 3 years ago

harrilewis commented 3 years ago

Description:

When I create a custom object within Grasshopper with Brep data I receive the following error:

"1. This component failed to run properly. Inputs cannot be collected properly. The best overloaded method match for 'BH.Engine.Geometry.Query.CurveIntersections(BH.oM.Geometry.Arc, BH.oM.Geometry.Arc, double)' has some invalid arguments"

Steps to reproduce:

To reproduce it seems you need a Brep with an Arc as an edge.

Expected behaviour:

The Brep to be converted to BHoM.Geometry and back with no loss of data

Test file(s):

See attached Grasshopper file with internalised data.

BrepConvert.zip

al-fisher commented 3 years ago

Hey @harrilewis - thanks for raising this. Yes - as you highlighted above, this is an issue with the Rhinoceros converts for certain B-Reps. Will transfer this issue to the Rhinoceros_Toolkit, to track alongside other Rhino issues

al-fisher commented 3 years ago

As per @harrilewis's comments above. Seems to be an issue in converting Trimmed Nurbs with boundary's formed from curves out of the plane of the surface

See baked geometery - before and then after explicit casting to BHoM Geometry and back

epignatelli commented 3 years ago

It seems like we have some overloads for BH.Engine.Geometry.Query.CurveIntersections are missing?

LMarkowski commented 3 years ago

Hi @harrilewis, After further inspection it seems that in the most recent BHoM version this issue is no longer accurate. I'm closing this one and opening another two that will be more up-to-date. Trimmed surface does not convert to BHoMGeometry correctly - this one is probably the root of your issue. CreateCustom does not convert breps Cheers!