Remove error for extrusion convert

BHoM / Rhinoceros_Toolkit

Set of functionalities for communication with Rhinoceros

GNU Lesser General Public License v3.0

7 stars 4 forks source link

Remove error for extrusion convert #181

Closed IsakNaslundBh closed 3 years ago

IsakNaslundBh commented 4 years ago

Issues addressed by this PR

Closes #180

As stated in the issue, the error from the extrusions now failing to convert has started to pop up in GH, which just leads to confusions.

Before, this was dispatched from happening by the IsRhinoEquivalent method, but that does not seem to be called any longer. Simply removing the error gives the previous behaviour.

Test files

Simply create an extrusion. Should not display an error message:

Changelog

Additional comments

FraserGreenroyd commented 4 years ago

/azp run Rhinoceros_Toolkit.CheckInstaller

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 1 pipeline(s).

adecler commented 4 years ago

The error message appears because the preview is failing for Extrusion . Previously, those preview error messages were filtered out but that filter has now been removed at @IsakNaslundBh ' s request.

Personally, I don't thing removing that error message is the right thing to do as it doesn't make sense to do so outside of the context of Grasshopper's preview. So I would rather have that conversion implemented.

Happy to follow the majority and let this PR be merged though. If you do, I would just recommend raising an issue to flag the need to implement that method.

IsakNaslundBh commented 3 years ago

Issue raised here:

https://github.com/BHoM/Rhinoceros_Toolkit/issues/182

And regarding the message, the issue was it was displayed on general component, making it look like any method returning an extrusion is not implemented. I agree simply removing the error might not be the best way, but it is for sure better than keeping it as it stands now.