Closed alelom closed 3 years ago
This change during the current Milestone has broken the component FromRhino: https://github.com/BHoM/Rhinoceros_Toolkit/pull/178/files#diff-3172cad297267b3731759fe48c33df6704aca3363264c6538b2167bace68d56eR669-R681
The null check needs to be changed.
Open the script: https://burohappold.sharepoint.com/:f:/s/BHoM/EoVl3E4-5gRAr4kqCF6zyWcB-te-XrdJBYh7IqEc8oOqkw?e=gDkqE7
If you open the script using BHoM v.3.3, you see the component FromRhino behaves correctly:
If you open the script using latest master, the component returns the error "No conversion could be found between [object] and Rhino geometry."
No error should be returned, conversion should succeed.
See above.
Description:
This change during the current Milestone has broken the component FromRhino: https://github.com/BHoM/Rhinoceros_Toolkit/pull/178/files#diff-3172cad297267b3731759fe48c33df6704aca3363264c6538b2167bace68d56eR669-R681
The null check needs to be changed.
Steps to reproduce:
Open the script: https://burohappold.sharepoint.com/:f:/s/BHoM/EoVl3E4-5gRAr4kqCF6zyWcB-te-XrdJBYh7IqEc8oOqkw?e=gDkqE7
If you open the script using BHoM v.3.3, you see the component FromRhino behaves correctly:
If you open the script using latest master, the component returns the error "No conversion could be found between [object] and Rhino geometry."
Expected behaviour:
No error should be returned, conversion should succeed.
Test file(s):
See above.