search

BHoM / Rhinoceros_Toolkit

Set of functionalities for communication with Rhinoceros
GNU Lesser General Public License v3.0
6 stars 3 forks source link

Fix FromRhino null check in the fallback method #185

Closed alelom closed 3 years ago

alelom commented 3 years ago

Issues addressed by this PR

Closes #184

Corrects a wrong check done in the fallback method for the IFromRhino conversion. See issue text.

Test files

See #184

Changelog

Additional comments

IsakNaslundBh commented 3 years ago

/azp run Rhinoceros_Toolkit.CheckInstaller

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 1 pipeline(s).
alelom commented 3 years ago

A bit puzzled as to why this would be needed, as it indicates we are trying to covert BHoM geometry from rhino to BHoM somewhere, but can not see this PR hurting anything really, so happy to approve.

Thanks for the approval.
Agreed, I am confused as well. However, the priority at the moment should be that this should work: image

which is what this PR fixes.

I don't know what happens in Grasshopper_Toolkit and we do not have time to investigate unfortunately, but this PR fixes the problem with a workaround that does not hurt any existing data propagation.