Closed IsakNaslundBh closed 1 year ago
/azp run Rhinoceros_Toolkit.CheckInstaller
Based on conversation earlier we should reopen https://github.com/BHoM/Rhinoceros_Toolkit/issues/67 to create and adapter for Rhino initially to handle the method in this PR.
Converted this to draft to keep it off Fraser's open PR radar.
@BHoMBot check versioning
@BHoMBot check compliance
@BHoMBot check core @BHoMBot check null-handling @BHoMBot check serialisation
@BHoMBot check ready-to-merge
NOTE: Depends on
Issues addressed by this PR
Closes #199
Adding a compute method that lets you feed in a list of filepaths and the method returns all geometry objects in those models as well as a concatenated layer name and layer colour.
There are some weirdness with how this is running which makes it trigger multiple times when called from GH.
I think I managed to solve the worst issue by the addition of a static boolean that returns if the method is already running. Not the best solution, but what I could think of on the spot.
This also means the method returns one empty branch and one filled branch in GH. Again, far from ideal, but at least lets you progress.
Would have also liked to add the option of generating a fresh model once it was done, but that command seem to have been added in rhino 6, so not possible for rhino 5 which we still support.
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/EpskE0cM0mBPpvr5gA3Tu50Bs-4BTimcJ18VxbSqmVXulA?e=oq1QPy
Changelog
Additional comments
As this is not working perfectly, I would be fine with this not being merged, if deemed to unreliable, but raising the PR to get the code up here as it was useful for some current project work (with all its flaws).
Also, if this is in any way clashing with https://github.com/BHoM/Rhinoceros_Toolkit/pull/198 and the representation work, please do not let this get in the way!