BHoM / Rhinoceros_Toolkit

Set of functionalities for communication with Rhinoceros
GNU Lesser General Public License v3.0
6 stars 3 forks source link

Changing to using BHoM join instead of RhinoJoin when converting polycurves to avoid Rhino Crash #221

Closed IsakNaslundBh closed 2 years ago

IsakNaslundBh commented 2 years ago

NOTE: Depends on

Issues addressed by this PR

Closes #220

Using BHoM Join instead of Rhino join to check if the curve can be coverted.

This is to avoid full blown crashes of Rhino from happening that can for some cases be triggered by the Rhino.Join method that was used.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/Rhinoceros_Toolkit/%23221-AvoidCallingRhinoJoinToStopRhinoCrashWhenConvertingPolycurves?csf=1&web=1&e=UMB25Z

Changelog

Additional comments

FraserGreenroyd commented 2 years ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance` There are 1 requests in the queue ahead of you.
FraserGreenroyd commented 2 years ago

@BHoMBot check required

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `core` - `null-handling` - `serialisation` - `versioning` - `installer`
bhombot-ci[bot] commented 2 years ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 years ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 2 years ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `ready-to-merge`
bhombot-ci[bot] commented 2 years ago
FAO: @FraserGreenroyd @FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is ready-to-merge. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `6129722289`
FraserGreenroyd commented 2 years ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6129722289

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd I have now provided a passing check on reference `6129722289` as requested.