BHoM / Rhinoceros_Toolkit

Set of functionalities for communication with Rhinoceros
GNU Lesser General Public License v3.0
6 stars 2 forks source link

Add view capturing capability #230

Closed IsakNaslundBh closed 1 year ago

IsakNaslundBh commented 1 year ago

Issues addressed by this PR

Closes #224

Add capability to capture rhino view.

Note that this requires an uptick in the nugets to Rhino 6, as the ViewCapture class used is internal in rhino 5. There are ways around this for rhino 5 as well, but from testing them, they perform significantly worse and does not give the same level of control.

Before this PR is merged an agreement that this uptick is ok, as it means no more support for rhino 5 (as in, might still work, but can not be as relied upon any longer). @al-fisher @FraserGreenroyd , have discussed this with you before raising this, but noting you in here as well.

Test files

Changelog

Additional comments

FraserGreenroyd commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 27 requests in the queue ahead of you.
michaelhoehn commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 1 year ago
@michaelhoehn fix requested for copyright headers. The errors with the copyright headers on the CS (`.cs`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS (`.cs`) file that does not have the current copyright header will have it applied. The current copyright header can be examined [here](https://github.com/BHoM/BHoM/blob/main/COPYRIGHT_HEADER.txt). If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix copyright headers ref. `10441140689`
michaelhoehn commented 1 year ago

@BHoMBot fix copyright headers ref. 10441140689

bhombot-ci[bot] commented 1 year ago
@michaelhoehn I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@michaelhoehn I'm sorry, but I cannot take that instruction from you. As this action would modify this Pull Request, this instruction can only come via an authorised user, per our [Code of Conduct for Bots](https://github.com/BHoM/BHoM/blob/main/docs/CODE_OF_CONDUCT_FOR_BOTS.md)
bhombot-ci[bot] commented 1 year ago
@michaelhoehn fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `10441133049`
FraserGreenroyd commented 1 year ago

@BHoMBot fix copyright headers ref. 10441140689

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.
michaelhoehn commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
michaelhoehn commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@michaelhoehn to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
FraserGreenroyd commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 1 year ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `project-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 1 year ago

@BHoMBot check null-handling

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `null-handling` There are 1 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check null-handling

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `null-handling`
FraserGreenroyd commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
FraserGreenroyd commented 1 year ago

@BHoMBot check core @BHoMBot check serialisation @BHoMBot check versioning

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `core` - check `serialisation` - check `versioning`
FraserGreenroyd commented 1 year ago

@BHoMBot check versioning

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning`
FraserGreenroyd commented 1 year ago

@BHoMBot check versioning

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning` There are 18 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

I think I've figured out why versioning is failing - installer would too if we ran it - LadybugTools_Toolkit has a dependency on this toolkit, I think this PR is breaking LadybugTools_Toolkit's ability to compile, thus resulting in versioning issues when the methods/objects don't exist.

I will take another look when back on the laptop to see if I can compile LadybugTools_Toolkit against this branch and if not, work out what the rectification might need to be early in the week with @tg359

FraserGreenroyd commented 1 year ago

@BHoMBot check versioning

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning`
FraserGreenroyd commented 1 year ago

@BHoMBot check installer

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `installer`
bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on LadybugTools_Toolkit
bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Grasshopper_UI
bhombot-ci[bot] commented 1 year ago
FAO: @FraserGreenroyd @FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is null-handling. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `10455686053`
FraserGreenroyd commented 1 year ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10455686053

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have now provided a passing check on reference `10455686053` as requested.
IsakNaslundBh commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge`