Closed IsakNaslundBh closed 1 year ago
@BHoMBot check compliance
@BHoMBot check compliance
@BHoMBot fix copyright headers ref. 10441140689
@BHoMBot fix copyright headers ref. 10441140689
@BHoMBot check compliance
@BHoMBot check compliance
@BHoMBot check required
@BHoMBot check null-handling
@BHoMBot check null-handling
@BHoMBot check compliance
@BHoMBot check core @BHoMBot check serialisation @BHoMBot check versioning
@BHoMBot check versioning
@BHoMBot check versioning
I think I've figured out why versioning is failing - installer would too if we ran it - LadybugTools_Toolkit has a dependency on this toolkit, I think this PR is breaking LadybugTools_Toolkit's ability to compile, thus resulting in versioning issues when the methods/objects don't exist.
I will take another look when back on the laptop to see if I can compile LadybugTools_Toolkit against this branch and if not, work out what the rectification might need to be early in the week with @tg359
@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10455686053
@BHoMBot check ready-to-merge
Issues addressed by this PR
Closes #224
Add capability to capture rhino view.
Note that this requires an uptick in the nugets to Rhino 6, as the ViewCapture class used is internal in rhino 5. There are ways around this for rhino 5 as well, but from testing them, they perform significantly worse and does not give the same level of control.
Before this PR is merged an agreement that this uptick is ok, as it means no more support for rhino 5 (as in, might still work, but can not be as relied upon any longer). @al-fisher @FraserGreenroyd , have discussed this with you before raising this, but noting you in here as well.
Test files
Changelog
Additional comments