search

BHoM / Rhinoceros_Toolkit

Set of functionalities for communication with Rhinoceros
GNU Lesser General Public License v3.0
6 stars 3 forks source link

Rhino_Toolkit : List<ISurface>.ToRhino not returning closed Brep from BHoM.BoundaryRepresentation #91

Open al-fisher opened 5 years ago

al-fisher commented 5 years ago

Failure in method below to effectively close/join the Rhino Brep after creation. 

public static RHG.Brep ToRhino(this List<BHG.ISurface> surfaces)

image

al-fisher commented 4 years ago

New test files provided here:

https://burohappold.sharepoint.com/sites/BHoM/02_Current/Forms/AllItems.aspx?RootFolder=%2Fsites%2FBHoM%2F02%5FCurrent%2F12%5FScripts%2F01%5FTest%20Scripts%2FRhinoceros%5FToolkit%2FRhinoceros%5FToolkit%2DIssue91%2DClosedBRep&FolderCTID=0x0120008122C8891F89054B8ACED0196C70DFC4

al-fisher commented 4 years ago

See comment on PR here: https://github.com/BHoM/Rhinoceros_Toolkit/pull/171#pullrequestreview-483656662

image

michaelhoehn commented 9 months ago

Potentially related issue https://github.com/BHoM/Rhinoceros_Toolkit/issues/121

michaelhoehn commented 9 months ago

Worth looking into this more closely in 7.1.