search

BHoM / Robot_Toolkit

Tools for Robot Structural Analysis
GNU Lesser General Public License v3.0
11 stars 3 forks source link

Robot_Toolkit: Add support for constraints with other axis than global #212

Open IsakNaslundBh opened 5 years ago

IsakNaslundBh commented 5 years ago

Currently only global XY supported for node constraints. Needs to be updated to follow the coordinate system of the node.

FredericBourgeon commented 5 years ago

Willing to take a crack at it to the best of my (limited) ability.

Had a look at Robot API, and it seems like we'll need using alpha, beta and gamma angles as defined in IRobotNodeSupportData. From my first guess, I believe the following files should be modified:

Other files should probably be modified, especially when pulling from Robot.

Any further guidance regarding what should be kept, added or removed is welcome!

rwemay commented 5 years ago

Hey Frederic, this looks right - create and convert methods sound good.

al-fisher commented 5 years ago

Perfect - thanks @FredericBourgeon - a good way in.

If you haven't already spotted open PRs https://github.com/BHoM/Robot_Toolkit/pull/219 & https://github.com/BHoM/BHoM/pull/481 & https://github.com/BHoM/BHoM_Engine/pull/951 in particular - then do have a look.

@IsakNaslundBh and @FraserGreenroyd have been simplifying and coordinating the Structure and Environment oMs as per https://github.com/BHoM/BHoM/projects/1 which will affect this issue

FredericBourgeon commented 5 years ago

Standing by for PR #219 to merge with master as the changes are extensive over nodes and constraints.

rwemay commented 4 years ago

Hey guys - what's the status of this - apologies @FredericBourgeon if it's been overlooked! Good to bring it back to life and get reviewed/merged.

FredericBourgeon commented 4 years ago

I have not taken the time to dig in the changes following #219. From memory, it didn't look as straight-forward as I thought. I'll reevaluate this week (work deadline allowing).