Robot_Toolkit: Fix MeshResults crash on non-planar meshes

IsakLarbornBH commented 3 years ago

Closes #452

Fixes crash in MeshResultRequest pulls on non-planar meshes, by making them use FEMesh objects instead of Panel.

A test file can be found on the issue page. I'd make Unit tests if I knew how they worked for adapter methods.

With this change the ObjectIds parameter in MeshResultRequests does nothing, results for all meshes are always returned. This seems to be, as far as I can tell, due to ReadMeshes() not using its List<string> ids input.
The new version is slightly slower, likely due to using the full ReadMeshes() method instead of ReadPanelsLight(). The difference is less than 5% though, so it's not a huge deal. Reading the actual results appears to be what takes the most time by far.

IsakNaslundBh commented 3 years ago

@BHoMBot check installer

bhombot-ci[bot] commented 3 years ago

@IsakNaslundBh to confirm, `check-installer` task is now queued.

BHoM / Robot_Toolkit