BHoM / Robot_Toolkit

Tools for Robot Structural Analysis
GNU Lesser General Public License v3.0
11 stars 3 forks source link

Robot toolkit: Add support for tapered sections #478

Closed IsakNaslundBh closed 1 year ago

IsakNaslundBh commented 2 years ago

NOTE: Depends on

Issues addressed by this PR

Closes #477

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EpgVkfEZy_hNlPfsVgicUJ8BvBNoLwyeZPFg7nvmAasZ8g?e=Dl3BL7

Changelog

Additional comments

IsakNaslundBh commented 2 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh to confirm, the following checks are now queued: - `copyright-compliance`
bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh fix requested for copyright headers. The errors with the copyright headers on the CS (`.cs`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS (`.cs`) file that does not have the current copyright header will have it applied. The current copyright header can be examined [here](https://github.com/BHoM/BHoM/blob/main/COPYRIGHT_HEADER.txt). If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix copyright headers ref. `4842799234`
IsakNaslundBh commented 2 years ago

@BHoMBot fix copyright headers ref. 4842799234

bhombot-ci[bot] commented 2 years ago
@isaknaslundbh I am now going to fix the copyright compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 2 years ago
@isaknaslundbh to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.
IsakNaslundBh commented 2 years ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance`
IsakNaslundBh commented 1 year ago

Ran through the test script and pushed to robot. Double checked that all values match what is defined in Grasshopper. Everything works except for Angle(L) profile and RectangularToBox profile. Also seems to be a bug with tapered fabricatedBoxProfile where none of the sizes are displayed in the Sections tab (see image), but the object with the profile still seems to be created correctly with all the right values. Also checked with my own project script and all tapered sections gets pushed correctly. TaperedFabricatedBoxProfileRobotBug

Thanks @TosteSkDa .

The angle as well as Box to rectangle failing are expected, and at least my end, warning messages are raised about this.

The fabricated box on the other hand I think is an actual issue where Robot doesnt seem to support the "Box3" option for tapered sections. Will ahve a look at this and try to fix!

IsakNaslundBh commented 1 year ago

@TosteSkDa have pushed a fix for the box sections now, if you can have another look! :)

IsakNaslundBh commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
IsakNaslundBh commented 1 year ago

@BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 17 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge` There are 27 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.