BHoM / Robot_Toolkit

Tools for Robot Structural Analysis
GNU Lesser General Public License v3.0
11 stars 3 forks source link

Add load dependencies on Dependency Types #506

Closed alelom closed 1 year ago

alelom commented 1 year ago

Issues addressed by this PR

Closes #505

Test files

Changelog

Additional comments

IsakNaslundBh commented 1 year ago

@BHoMBot check compliance @BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 1 year ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 1 year ago

Found an issue on the base adapter regarding dependencies that needs to be handled before this is merged.

Putting a Do-not merge tag on this PR until resolved.

Issue raised here: https://github.com/BHoM/BHoM_Adapter/issues/339

Apart from that I am generally happy with this PR.

IsakNaslundBh commented 1 year ago

Now, with the Adapter PR merged, happy for this to go in

IsakNaslundBh commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge`