DOFType: FixedPositive/FixedNegative for Translation in Constrain6DOF Not Working

BHoM / Robot_Toolkit

Tools for Robot Structural Analysis

GNU Lesser General Public License v3.0

11 stars 3 forks source link

DOFType: FixedPositive/FixedNegative for Translation in Constrain6DOF Not Working #530

Open dextertuay99 opened 9 months ago

dextertuay99 commented 9 months ago

keyword: BHoM, Robot, Panel, Edges, Support

Description: I would like to assign at the same time, both:

Rigid Support with either +ve/-ve uplift
Elastic Support with elastic coef.

However, I notice there's no difference between DOFType FixedPositive/FixedNegative

Steps to reproduce:

DOFType: FixedPositive
Constrain6DOF: TranslationX
Edge: Support
Edges: Curve <- ExternalEdges <- Object (pull from Robot)
Panel: externalEdges
Push (to robot): object

Expected behaviour: I'm expecting for both:

Rigid Support with either +ve/-ve uplift
Elastic Support with elastic coef.

Any help?

FraserGreenroyd commented 9 months ago

@Chrisshort92 @peterjamesnugent @johannaisak can any of you help?

peterjamesnugent commented 9 months ago

Hi @dextertuay99, I believe it is because DOFType.FixedPositive and DOFType.FixedNegative are not currently implemented within the Robot_Toolkit - hence why they are coming back as DOFType.Free when you push them in to Robot:

https://github.com/BHoM/Robot_Toolkit/blob/aafb6067b31db673ca3a08c0ea7e08bb07ee2b3e/Robot_Adapter/Convert/ToRobot/Properties/Support.cs#L34-L48

The current implementation supports DOFType Fixed, Free and Spring.

Do you have any experience using Robot API? If this is a bug you could write a fix for, I would be happy to assist and review.

peterjamesnugent commented 9 months ago

@dextertuay99 will be something along the lines of this: suppData.SetOneDir(IRobotNodeSupportFixingDirection.I_NSFD_UZ, IRobotNodeSupportOneDirectionFixingType.I_NSODFT_PLUS);